Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Call): Show feedback when user B deny call #723

Merged
merged 10 commits into from
Oct 17, 2024
Merged

fix(Call): Show feedback when user B deny call #723

merged 10 commits into from
Oct 17, 2024

Conversation

lgmarchi
Copy link
Collaborator

@lgmarchi lgmarchi commented Oct 16, 2024 •
edited
Loading

What this PR does 📖

  • Show feedback when user B deny call
  • Should work if Group has 4 participants for example, and 3 of them deny the call
image

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

@lgmarchi lgmarchi requested a review from Flemmli97 October 16, 2024 19:51
@lgmarchi lgmarchi self-assigned this Oct 16, 2024
@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Oct 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

Download the app installers for this pull request:

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

@github-actions github-actions bot added the Missing fixing conflict Needs to fix conflicts label Oct 16, 2024
@github-actions github-actions bot removed the Missing fixing conflict Needs to fix conflicts label Oct 16, 2024
@phillsatellite phillsatellite added the QA Approved PR has been tested by QA Team label Oct 16, 2024
@lgmarchi lgmarchi merged commit cdff6cc into dev Oct 17, 2024
10 checks passed
@lgmarchi lgmarchi deleted the show-feedback-when-userB-deny-call branch October 17, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@stavares843 stavares843 stavares843 approved these changes

@ashneverdawn ashneverdawn ashneverdawn approved these changes

@Flemmli97 Flemmli97 Awaiting requested review from Flemmli97

Assignees

@lgmarchi lgmarchi

Labels
Missing dev review Two dev reviews are required on PR QA Approved PR has been tested by QA Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lgmarchi @ashneverdawn @stavares843 @phillsatellite @luisecm